Skip to content

feat: impl PeekingNext for vec::IntoIter #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2025
Merged

feat: impl PeekingNext for vec::IntoIter #1059

merged 5 commits into from
Sep 26, 2025
+51 −0

Conversation

aatifsyed
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.61%. Comparing base (6814180) to head (41de9d3).
⚠️ Report is 161 commits behind head on master.

Files with missing lines Patch % Lines
src/peeking_take_while.rs 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   94.38%   93.61%   -0.78%     
==========================================
  Files          48       50       +2     
  Lines        6665     6282     -383     
==========================================
- Hits         6291     5881     -410     
- Misses        374      401      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

phimuemue
phimuemue requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for this.

Do you want to include the others mentioned in #1045, too?

  • vec::Drain
  • array::IntoIter
  • string::Drain

@aatifsyed
Copy link
Contributor Author

I have added the requested impls :)

@aatifsyed aatifsyed requested a review from phimuemue September 26, 2025 20:10
phimuemue
phimuemue approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@phimuemue phimuemue added this pull request to the merge queue Sep 26, 2025
Merged via the queue into rust-itertools:master with commit f6bd955 Sep 26, 2025
11 of 14 checks passed
@phimuemue phimuemue mentioned this pull request Sep 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phimuemue phimuemue phimuemue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aatifsyed @phimuemue